[RaisedButton] Fix backgroundColor property #3579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ function getStyles(props, state) { | |||
|
|
|||
| const amount = (primary || secondary) ? 0.4 : 0.08; | |||
|
|
|||
| let backgroundColor = raisedButton.color; | |||
| let backgroundColor = props.backgroundColor || raisedButton.color; | |||
There was a problem hiding this comment.
Can you deconstruct it at the top of the render() function. Should be good after that 👍
nathanmarks
added
the
PR: needs revision
mbrookes
changed the title
|
Ping @lubosz |
|
Fixed in #3515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backgroundColor property currently does not have any effect on RaisedButton.
As documented RaisedButton should provide a backgroundColor property:
http://www.material-ui.com/v0.15.0-alpha.1/#/components/floating-action-button
Updating from 0.11.0 to 0.15.0-alpha.1 broke this behavior for me.
8587247 seems to be the commit introducing the not working code.
The following patch makes RaidedButton use the property again, like seen in FloatingActionButton:
https://github.com/callemall/material-ui/blob/master/src/floating-action-button.jsx#L17