Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridRenderCellParams example in the docs is incorrect [docs] #10431

Closed
1 task done
vladmihaisima opened this issue Sep 22, 2023 · 1 comment · Fixed by #10435
Closed
1 task done

GridRenderCellParams example in the docs is incorrect [docs] #10431

vladmihaisima opened this issue Sep 22, 2023 · 1 comment · Fixed by #10435
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation support: docs-feedback Feedback from documentation page

Comments

@vladmihaisima
Copy link

Duplicates

  • I have searched the existing issues

Related page

https://mui.com/x/react-data-grid/column-definition/#rendering-cells

Kind of issue

Other

Issue description

The code shown as example for render cell contains:

renderCell: (params: GridRenderCellParams<Date>) => (

which is now incorrect (I assume, that it is due to #5603 )

Note: if clicking on "Show code" the code is correct and uses: (props: GridRenderCellParams<any, Date>)

Context 🔦

Use the code examples in the documentation.
@vladmihaisima vladmihaisima added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Sep 22, 2023
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Sep 22, 2023
@cherniavskii
Copy link
Member

Indeed, thanks!

@cherniavskii cherniavskii added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 22, 2023
@cherniavskii cherniavskii mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation support: docs-feedback Feedback from documentation page
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Fix usage of GridRenderCellParams interface cherniavskii/mui-x
3 participants
@vladmihaisima @cherniavskii @zannager