Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Facing issues due to disableExtendRowFullWidth prop removed in v6 #10656

Closed
TrofinSorin opened this issue Oct 12, 2023 · 6 comments
Closed
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine status: waiting for author Issue with insufficient information

Comments

@TrofinSorin
Copy link

TrofinSorin commented Oct 12, 2023

Steps to reproduce

Steps:

  1. disableExtendRowFullWidth works in v5
  2. disableExtendRowFullWidth was removed in v6
  3. How can I achieve the same functionality with disableExtendRowFullWidth on v6?
    On V6 with the removal of disableExtendRowFullWidth my table width is too big

Current behavior

On V6 with the removal of disableExtendRowFullWidth my table width is too big

Expected behavior

How can I achieve the same functionality with disableExtendRowFullWidth removed on v6?

Context

Achieve the same functionality with disableExtendRowFullWidth removed on v6

Your environment

npm: 6.14.17
@mui/x-data-grid": "^6.16.1

Search keywords: disableExtendRowFullWidth

@TrofinSorin TrofinSorin added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 12, 2023
@romgrk
Copy link
Contributor

romgrk commented Oct 12, 2023

cc @mui/xgrid Not sure what that prop did, can someone answer this one?

@cherniavskii
Copy link
Member

@TrofinSorin Can you clarify how was the disableExtendRowFullWidth prop useful in your case?
As far as I remember, it didn't impact the grid width.

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information feature: Rendering layout Related to the data grid Rendering engine and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 12, 2023
@MBilalShafi
Copy link
Member

@TrofinSorin Did you already have a look over the alternate suggested in the data grid v6 migration guide by any chance?

@TrofinSorin
Copy link
Author

TrofinSorin commented Oct 12, 2023

Based on v5 documentation: If true, rows will not be extended to fill the full width of the grid container.

@cherniavskii It helped me so the table won't have a very big width when using flex: 1 in the column config. Under 1060px screen width it starts to resize slowly and it's increasing it's width. I don't want it to be resized, how can i stop the resizing and have horizontal scroll inside it.
@MBilalShafi I did, it says only that it's been removed.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 12, 2023
@MBilalShafi
Copy link
Member

MBilalShafi commented Oct 13, 2023

If true, rows will not be extended to fill the full width of the grid container.

The only difference that prop was making was adding or removing the right border on the last column, which could be achieved by CSS or by showCellVerticalBorder and showHeaderVerticalBorder props. Check the original issue for the context. (Another related issue you might check out: #10472)

If you find it difficult to achieve it, share a couple of codesandboxes with before (v5) and after (v6) versions, I'll be happy to assist you to achieve a similar behavior.

@MBilalShafi MBilalShafi added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 13, 2023
@MBilalShafi MBilalShafi changed the title disableExtendRowFullWidth removed on V6, issues with table [data grid] Facing issues due to disableExtendRowFullWidth prop removed in v6 Oct 13, 2023
@github-actions
Copy link

The issue has been inactive for 7 days and has been automatically closed. If you think that it has been incorrectly closed, please reopen it and provide missing information (if any) or continue the last discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

4 participants