Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the dayPickerClasses variable dayCalendarClasses #11141

Closed
Tracked by #7902
flaviendelangle opened this issue Nov 22, 2023 · 3 comments · Fixed by #11140
Closed
Tracked by #7902

Rename the dayPickerClasses variable dayCalendarClasses #11141

flaviendelangle opened this issue Nov 22, 2023 · 3 comments · Fixed by #11140
Assignees
@flaviendelangle
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x

Comments

@flaviendelangle
Copy link
Member

flaviendelangle commented Nov 22, 2023 •
edited by github-actions bot
Loading

Renaming missed in v6.0.0
Part of #7902

Search keywords:
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x labels Nov 22, 2023
This was referenced Nov 22, 2023
Merged
Open
@flaviendelangle flaviendelangle self-assigned this Nov 22, 2023
@MonstraG
Copy link

Hey, why wasn't this mentioned in the breaking changes of the release https://github.com/mui/mui-x/releases/tag/v7.0.0?

@LukasTy
Copy link
Member

LukasTy commented Mar 27, 2024 •
edited
Loading

Because the v7.0.0 release only lists breaking changes introduced with that particular release.
This particular change has been released with @mui/[email protected].
This particular BC is also listed in the migration guide.
Do you think that something is missing? 🤔

@MonstraG
Copy link

No, I just totally forgot that migration guide exists, and assumed that the release would list all changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pickers] Rename the dayPickerClasses variable dayCalendarClasses flaviendelangle/mui-x
3 participants
@flaviendelangle @LukasTy @MonstraG