Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] rowSpanning makes group header disappear [#2] #15819

Closed
vanyadymousky opened this issue Dec 10, 2024 · 3 comments · Fixed by #15858
Closed

[data grid] rowSpanning makes group header disappear [#2] #15819

vanyadymousky opened this issue Dec 10, 2024 · 3 comments · Fixed by #15858
Assignees
@MBilalShafi
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@vanyadymousky
Copy link

vanyadymousky commented Dec 10, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

Steps:

  1. Open this link to live example: (required)
    On the example provided, press UPDATE THE DATA twice so second row is rendered while first is not

Current behavior

alias field is not being rendered: empty

Expected behavior

alias field should render: rowSpanning should render alias value always even there's only one row of a kind.

Context

Related issue: #15261
Please don't close this one! The issue is obvious: alias column value not being rendered.
Otherwise, if you exactly see how can this issue be resolved. Previous issue didn't help at all.

Your environment

npx @mui/envinfo 
    System:
    OS: macOS 15.1.1
  Binaries:
    Node: 20.16.0 - ~/.nvm/versions/node/v20.16.0/bin/node
    npm: 10.8.1 - ~/.nvm/versions/node/v20.16.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 131.0.6778.109
    Edge: Not Found
    Safari: 18.1.1
  npmPackages:
    @emotion/react: ^11.4.1 => 11.11.4 
    @emotion/styled: ^11.3.0 => 11.11.5 
    @mui/base:  5.0.0-beta.40 
    @mui/core-downloads-tracker:  5.16.7 
    @mui/icons-material: ^5.0.1 => 5.15.20 
    @mui/lab: ^5.0.0-alpha.49 => 5.0.0-alpha.170 
    @mui/material: ^5.0.2 => 5.16.7 
    @mui/private-theming:  5.16.6 
    @mui/styled-engine:  5.16.6 
    @mui/system:  5.16.7 
    @mui/types:  7.2.17 
    @mui/utils:  5.16.6 
    @mui/x-data-grid:  7.23.1 
    @mui/x-data-grid-pro: ^7.6.2 => 7.23.1 
    @mui/x-date-pickers: ^7.6.2 => 7.7.0 
    @mui/x-internals:  7.23.0 
    @mui/x-license:  7.23.0 
    @types/react: ^18.0.25 => 18.3.3 
    react: ^18.2.0 => 18.3.1 
    react-dom: ^18.2.0 => 18.3.1 
    typescript: 5.2.2 => 5.2.2

Used: Chrome: 131.0.6778.109

Search keywords: rowSpanning
Order ID: 60827
@vanyadymousky vanyadymousky added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 10, 2024
@github-actions github-actions bot added component: data grid This is the name of the generic UI component, not the React module! support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/ labels Dec 10, 2024
@michelengelen
Copy link
Member

Got you @vanyadymousky ... There seems to be a bug in the rowSpanning feature. This occurs when there is the same amount of rows updated, since the useCallback reference values are only shallow compared.

There may be a different cause as well, so no guarantee for precise investigation here.

I'll add it to the board!

cc @MBilalShafi

@michelengelen michelengelen added feature: Row spanning Related to the data grid Row spanning feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 10, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Dec 10, 2024
@MBilalShafi
Copy link
Member

Thank you @vanyadymousky for providing a reproduction example.
I can reproduce the issue on it.
Will try to raise a fix soon.

@MBilalShafi MBilalShafi self-assigned this Dec 11, 2024
@MBilalShafi MBilalShafi moved this from 🆕 Needs refinement to 🏗 In progress in MUI X Data Grid Dec 11, 2024
@MBilalShafi MBilalShafi mentioned this issue Dec 12, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@vanyadymousky How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/
Projects
MUI X Data Grid
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Trigger row spanning computation on rows update MBilalShafi/mui-x
3 participants
@vanyadymousky @MBilalShafi @michelengelen