Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Only allow a string for headerClassName #274

Closed
oliviertassinari opened this issue Sep 12, 2020 · 1 comment · Fixed by #1778
Closed

[RFC] Only allow a string for headerClassName #274

oliviertassinari opened this issue Sep 12, 2020 · 1 comment · Fixed by #1778
Assignees
@DanailH
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! RFC Request For Comments
Milestone
beta release

Comments

@oliviertassinari
Copy link
Member

For simplicity, I think that headerClassName could only accept a string. Developers are used to this constraint to React. I would also argue they we have thought them to use the clsx helper.
@oliviertassinari oliviertassinari added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Sep 12, 2020
@oliviertassinari oliviertassinari mentioned this issue Sep 12, 2020
Closed
@oliviertassinari oliviertassinari added this to the beta milestone Mar 26, 2021
@oliviertassinari oliviertassinari mentioned this issue Mar 26, 2021
Closed
1 task
@dtassone
Copy link
Member

dtassone commented May 24, 2021 •
edited by oliviertassinari
Loading

  1. Make the same type as GridColDef.cellClassname, ie add function support, and string
  2. Refactor type name
  3. Remove array type

@DanailH DanailH self-assigned this May 27, 2021
@DanailH DanailH mentioned this issue May 28, 2021
Merged
@oliviertassinari oliviertassinari added the RFC Request For Comments label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanailH DanailH

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! RFC Request For Comments
Projects
None yet
Milestone
beta release
Development

Successfully merging a pull request may close this issue.

[DataGrid] Improve headerClassName type DanailH/material-ui-x
3 participants
@dtassone @oliviertassinari @DanailH