Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] GridFilterPanel UI Issue #4061

Closed
2 tasks done
Hameezr opened this issue Mar 1, 2022 · 5 comments · Fixed by #3915
Closed
2 tasks done

[DataGrid] GridFilterPanel UI Issue #4061

Hameezr opened this issue Mar 1, 2022 · 5 comments · Fixed by #3915
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature

Comments

@Hameezr
Copy link
Contributor

Hameezr commented Mar 1, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Outlined variant doesn't work correctly.

While setting the variant of linkOperatorInputProps in FilterPanel, as outlined, the label cuts the outlined border.

Expected behavior 🤔

The variant outlined should not cut the border for the grid Filter Panel.

Steps to reproduce 🕹

Steps:

  1. Override componentProps for filter Panel
  2. Set variant as outlined for linkOperatorInputProps
  3. The label will cut the border
componentsProps={{
filterPanel: {
              filterFormProps: {
                linkOperatorInputProps: {
                  variant: 'outlined',
                  size: 'small',
                  sx: {mt: 'auto'},
                },
              },
           }
     }}

https://codesandbox.io/s/customfilterpanelcontent-material-demo-forked-948jwd?file=/demo.js:1865-1887

Context 🔦

I am trying to keep my theme consistent and use outlined textfields all over my app.

Your environment 🌎

`npx @mui/envinfo`
System:
    OS: macOS 12.0.1
  Binaries:
    Node: 14.17.2 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.14.13 - /usr/local/bin/npm
  Browsers:
    Chrome: 98.0.4758.109
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.1

Order ID 💳 (optional)

No response

@Hameezr Hameezr added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 1, 2022
@Hameezr Hameezr changed the title MUI-DataGrid Filter Panel UI Issue [DataGrid] MUI-DataGrid Filter Panel UI Issue Mar 1, 2022
@flaviendelangle
Copy link
Member

@alexfauquette it is probably related to #3497

@Hameezr
Copy link
Contributor Author

Hameezr commented Mar 1, 2022

@alexfauquette it is probably related to #3497
A screenshot to elaborate the issue
image

@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature labels Mar 1, 2022
@alexfauquette
Copy link
Member

This should be solved with #3915 Notice that "Operators" is used twice. To be exact we should write "logic operator" on the left one which is more disturbing than helping.

So the PR is about hiding the label and using arial-label to keep accessibility.

@Hameezr Does it solves your problem?

@Hameezr
Copy link
Contributor Author

Hameezr commented Mar 1, 2022

Hiding the Label would do the trick! I was curious is there any way to change the icons in the filter panel as well? If not, maybe I can add a contribution for it!

Thank you for your timely response! @alexfauquette @flaviendelangle

@flaviendelangle flaviendelangle changed the title [DataGrid] MUI-DataGrid Filter Panel UI Issue [DataGrid] GridFilterPanel UI Issue Mar 1, 2022
@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 1, 2022
@alexfauquette
Copy link
Member

alexfauquette commented Mar 1, 2022

To update icons, you have the slot which allows overriding components (including icons)

See the doc about overriding icons

If you encounter bugs with icons overriding, please open another issue, such that we can keep this one only about filter panel labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants