Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] Reduce scope of allowSameDateSelection prop #4727

Closed
oliviertassinari opened this issue Nov 19, 2020 · 0 comments · Fixed by #4808
Closed

[DatePicker] Reduce scope of allowSameDateSelection prop #4727

oliviertassinari opened this issue Nov 19, 2020 · 0 comments · Fixed by #4808
Assignees
@flaviendelangle
Labels
breaking change component: DatePicker The React component. component: pickers This is the name of the generic UI component, not the React module!

Comments

@oliviertassinari
Copy link
Member

The prop is described as:

https://github.com/mui-org/material-ui/blob/35e674311a97a72da806c04ba61e44fae79fdfee/packages/material-ui-lab/src/DesktopDateRangePicker/DesktopDateRangePicker.tsx#L29-L33

The prop is used for the date-time picker, in order to allow switching between the calendar and time view. We can reduce the scope of the prop to only be exposed where need. It should likely only be available for the PickersDay component.
@flaviendelangle flaviendelangle transferred this issue from mui/material-ui May 2, 2022
@flaviendelangle flaviendelangle self-assigned this May 2, 2022
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label May 2, 2022
@flaviendelangle flaviendelangle mentioned this issue May 2, 2022
Closed
@flaviendelangle flaviendelangle mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
breaking change component: DatePicker The React component. component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pickers] Drop allowSameDateSelection prop flaviendelangle/mui-x
2 participants
@oliviertassinari @flaviendelangle