Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Rename ErrorOverlay #5609

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6946
Closed
Tracked by #3287

[data grid] Rename ErrorOverlay #5609

joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6946
Assignees
@MBilalShafi
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x

Comments

@joserodolfofreitas
Copy link
Member

Summary

Breaking change for v6.
For more context: #3287

Rename ErrorOverlay => GridErrorOverlay

mui-x/packages/grid/x-data-grid/src/components/ErrorOverlay.tsx

Lines 13 to 14 in b778028

// TODO v6: rename to GridErrorOverlay
export const ErrorOverlay = React.forwardRef<HTMLDivElement, ErrorOverlayProps>(

Motivation

Naming consistency
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Jul 26, 2022
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@m4theushw m4theushw moved this to 📋 Backlog in MUI X Data Grid Oct 7, 2022
@DanailH DanailH self-assigned this Nov 18, 2022
@MBilalShafi MBilalShafi assigned MBilalShafi and unassigned DanailH Nov 21, 2022
@MBilalShafi MBilalShafi mentioned this issue Nov 21, 2022
Merged
@MBilalShafi MBilalShafi moved this from 📋 Backlog to 👀 In review in MUI X Data Grid Nov 21, 2022
@MBilalShafi MBilalShafi moved this from 👀 In review to ✅ Done in MUI X Data Grid Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Rename ErrorOverlay to GridErrorOverlay MBilalShafi/mui-x
3 participants
@joserodolfofreitas @DanailH @MBilalShafi