Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Rename the rowsScroll event to a wider name #5610

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6957
Closed
Tracked by #3287

[data grid] Rename the rowsScroll event to a wider name #5610

joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6957
Assignees
@DanailH
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience v6.x

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Jul 26, 2022 •
edited
Loading

Summary

Rename the rowsScroll event to a wider name

mui-x/packages/grid/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx

Lines 273 to 275 in b778028

// TODO v6: rename event to a wider name, it's not only fired for row scrolling
apiRef.current.publishEvent(
GridEvents.rowsScroll,

Motivation

DX: It's not only fired for row scrolling.
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x dx Related to developers' experience labels Jul 26, 2022
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@DanailH DanailH self-assigned this Nov 17, 2022
@DanailH DanailH mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanailH DanailH

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Rename rowsScroll event to scrollPositionChange DanailH/material-ui-x
2 participants
@joserodolfofreitas @DanailH