Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Do not toggle the panel with Ctrl+Enter #5613

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6945
Closed
Tracked by #3287

[data grid] Do not toggle the panel with Ctrl+Enter #5613

joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6945
Assignees
@MBilalShafi
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v6.x

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Jul 26, 2022 •
edited
Loading

Summary

Do not toggle the panel with Ctrl+Enter.

mui-x/packages/grid/x-data-grid-pro/src/hooks/features/detailPanel/useGridDetailPanel.ts

Lines 81 to 82 in b778028

if ((event.ctrlKey || event.metaKey) && event.key === 'Enter') {
// TODO v6: only support Space on the detail toggle

Motivation
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@joserodolfofreitas joserodolfofreitas changed the title Do not toggle the panel with Ctrl+Enter mui-x/packages/grid/x-data-grid-pro/src/hooks/features/detailPanel/useGridDetailPanel.ts Lines 81 to 82 in b778028 if ((event.ctrlKey || event.metaKey) && event.key === 'Enter') { // TODO v6: only support Space on the detail toggle [data grid] Do not toggle the panel with Ctrl+Enter Jul 26, 2022
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x design: ux labels Jul 26, 2022
@m4theushw m4theushw moved this to 🆕 Needs refinement in MUI X Data Grid Oct 7, 2022
@m4theushw m4theushw moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Oct 7, 2022
@MBilalShafi MBilalShafi self-assigned this Nov 21, 2022
@MBilalShafi MBilalShafi moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Nov 21, 2022
@MBilalShafi MBilalShafi mentioned this issue Nov 21, 2022
Merged
@MBilalShafi MBilalShafi moved this from 🏗 In progress to 👀 In review in MUI X Data Grid Nov 21, 2022
@MBilalShafi MBilalShafi moved this from 👀 In review to ✅ Done in MUI X Data Grid Nov 23, 2022
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v6.x
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Prevents master detail panel toggle with Ctrl+Enter MBilalShafi/mui-x
3 participants
@joserodolfofreitas @oliviertassinari @MBilalShafi