Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Stop exporting the root selector gridSortingStateSelector #5622

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6912
Closed
Tracked by #3287

[data grid] Stop exporting the root selector gridSortingStateSelector #5622

joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6912
Assignees
@DanailH
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience feature: Sorting Related to the data grid Sorting feature v6.x

Comments

@joserodolfofreitas
Copy link
Member

Summary

Stop exporting the root selector gridSortingStateSelector (avoid making the whole state.sorting public)

mui-x/packages/grid/x-data-grid/src/hooks/features/sorting/gridSortingSelector.ts

Line 10 in b778028

export const gridSortingStateSelector = (state: GridStateCommunity) => state.sorting;

Motivation
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x feature: Sorting Related to the data grid Sorting feature dx Related to developers' experience labels Jul 26, 2022
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@DanailH DanailH self-assigned this Nov 17, 2022
@DanailH DanailH mentioned this issue Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanailH DanailH

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience feature: Sorting Related to the data grid Sorting feature v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Stop exporting root base state selectors DanailH/material-ui-x
2 participants
@joserodolfofreitas @DanailH