-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fields] Refactor to use multiple elements to support a11y #6384
Comments
|
Any update as to what implementation was done @LukasTy ? |
@kylane We have gone with an approach of having a separate If you see any potential problems with the solution or have suggestions—we are open to hearing any kind of feedback. 🙏 |
Gday @LukasTy - thanks for that - sorry, been dragged in other directions since my original post. Just testing this now - It still doesnt give at-time feedback for an invalid value (say for month) and auto corrects it without feedback at the time of typing. I have set the textfield slot to variant "standard" but the underline styling of the input seems missing? Also, Im not getting any of the helpertext read out, even in an error state. Looks promising though. Any advice from here? |
Thank you for the feedback @kylane! 🙏
The behavior of the value (section) management is mostly identical between the approaches.
This is an actual problem that we'll address. I've created #12825 for this and other concerns.
We'll have to explore it, maybe there is some problem with id mapping. |
Appreciate the time you guys put in :)
If I type 34 in for a day value (invalid) it autocorrects to 04, but doesnt alert the user (screen reader) at that time. It only reads back the date once all 3 "fields" have been entered, then they have to go back. Look, Im likely being picky - its still "usable" but, its still not an ideal situation where the value the user has entered is changed without their knowledge (likely later then its read out).
Appreciate it!
Appreciate that too, and you guys. Keep up the awesome work. |
Without at all trying to appear condescending, Ive sent my dev to this resource on the regular: https://www.digitala11y.com/accessible-date-pickers-roundup/ - it has some great explanations and concepts. |
@LukasTy Have we had any progress? |
The new
DateField
(and their sibling components) need custom a11y implementation to be accessible by screen readers.W3 Aria has an example of date picker component with spin buttons. Their example looks and feels (functionality) very similar to our
DateField
component behaviour, hence, it could make a very good base for a11y support in the component.Exploration notes
value
attribute as well as custom section selecting interferes with screen readers ability to announce proper aria attribute denoted data.Possible exploration
spinbutton
divs (overlaying the underlying input element), which would intercept tabulation/click events, propagate those events to the actual field and update the spinbutton aria attributes accordingly (it seems like tedious and janky solution to achieve pretty simple result easily doable with different field implementations)After exploration
Results uncovered in #7334 proved that the only logical path is to refactor the field component rendering in order to achieve the desired
spinbutton
behavior. Other implementations seem like hacks, without a correct tangible result.The text was updated successfully, but these errors were encountered: