Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] components -> slots API rename #6986

Closed
2 tasks done
cherniavskii opened this issue Nov 24, 2022 · 0 comments · Fixed by #7882
Closed
2 tasks done

[core] components -> slots API rename #6986

cherniavskii opened this issue Nov 24, 2022 · 0 comments · Fixed by #7882
Assignees
@MBilalShafi
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes deprecation New deprecation message

Comments

@cherniavskii
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

MUI ecosystem is adopting a new naming convention for slots:

MUI X should adopt the same convention as well.
We can do this in two ways:

  1. Introduce breaking changes by renaming the props (like MUI Base and Joy UI did). This change can be included in the codemod
  2. Deprecate the old API and add a new one as Material UI did. This will make migration easier.

Examples 🌈

No response

Motivation 🔦

No response

Order ID 💳 (optional)

No response
@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Nov 24, 2022
This was referenced Nov 24, 2022
Closed
Merged
@DanailH DanailH self-assigned this Nov 28, 2022
@DanailH DanailH mentioned this issue Dec 1, 2022
Closed
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Jan 25, 2023
@joserodolfofreitas joserodolfofreitas moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Jan 25, 2023
@joserodolfofreitas joserodolfofreitas moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Jan 25, 2023
@MBilalShafi MBilalShafi assigned MBilalShafi and unassigned DanailH Feb 8, 2023
@MBilalShafi MBilalShafi added the component: data grid This is the name of the generic UI component, not the React module! label Feb 10, 2023
@MBilalShafi MBilalShafi mentioned this issue Feb 10, 2023
Merged
@MBilalShafi MBilalShafi moved this from 🏗 In progress to 👀 In review in MUI X Data Grid Feb 11, 2023
@MBilalShafi MBilalShafi moved this from 👀 In review to ✅ Done in MUI X Data Grid Feb 18, 2023
@MBilalShafi MBilalShafi mentioned this issue Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes deprecation New deprecation message
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
4 participants
@oliviertassinari @DanailH @MBilalShafi @cherniavskii