Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to memoize rows when pinnedColumns are set #9013

Closed
2 tasks done
martinhonza opened this issue May 16, 2023 · 2 comments · Fixed by #9037
Closed
2 tasks done

Possibility to memoize rows when pinnedColumns are set #9013

martinhonza opened this issue May 16, 2023 · 2 comments · Fixed by #9037
Assignees
@romgrk
Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user

Comments

@martinhonza
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Hi,
would it be possible to implement row memoization also if there are columns that are pinned ?
We currently pin by default the checkbox column and it causes the row memoization to fail, it fails at comparing renderedColumns although if I put into memo deepEqual it passes as equal.

Examples 🌈

https://codesandbox.io/s/strange-shadow-717s3z?file=/demo.tsx

Motivation 🔦

No response

Order ID 💳 (optional)

#54652
@martinhonza martinhonza added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 16, 2023
@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user labels May 17, 2023
@m4theushw m4theushw removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 17, 2023
@m4theushw
Copy link
Member

One solution is to cache the content of getRows in useGridVirtualScroller, or do the inverse and memoize the content of getRows in DataGridProVirtualScroller.

@m4theushw m4theushw moved this from 🆕 Needs refinement to 📋 Backlog in MUI X Data Grid May 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid May 17, 2023
@romgrk romgrk self-assigned this May 18, 2023
@romgrk
Copy link
Contributor

romgrk commented May 18, 2023

I'll cover this as part of #9001 work.

@martinhonza martinhonza mentioned this issue May 24, 2023
Closed
2 tasks
@romgrk romgrk mentioned this issue May 24, 2023
Merged
6 tasks
@m4theushw m4theushw moved this from 📋 Backlog to ✅ Done in MUI X Data Grid Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romgrk romgrk

Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Scroll performance improvements romgrk/mui-x
4 participants
@romgrk @martinhonza @m4theushw @zannager