Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Exclude hidden columns from quick filtering by default #9655

Closed
Tracked by #7902
cherniavskii opened this issue Jul 12, 2023 · 0 comments · Fixed by #11229
Closed
Tracked by #7902

[DataGrid] Exclude hidden columns from quick filtering by default #9655

cherniavskii opened this issue Jul 12, 2023 · 0 comments · Fixed by #11229
Assignees
@cherniavskii
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature v7.x

Comments

@cherniavskii
Copy link
Member

When using quick filter, it searches through hidden columns by default.
Sometimes it could be confusing to a user searching for a value:

Why does this row pass the filter?

Because it has a hidden column with a matching value:

In #9610 we added an option to exclude hidden columns in quick filter.
I think we should do this by default in v7.
@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature v7.x labels Jul 12, 2023
@cherniavskii cherniavskii mentioned this issue Jul 12, 2023
Open
45 tasks
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Oct 17, 2023
@cherniavskii cherniavskii moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Oct 17, 2023
@cherniavskii cherniavskii self-assigned this Nov 28, 2023
@cherniavskii cherniavskii mentioned this issue Nov 28, 2023
Merged
@cherniavskii cherniavskii moved this from 🔖 Ready to ✅ Done in MUI X Data Grid Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherniavskii cherniavskii

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature v7.x
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Exclude hidden columns from quick filtering by default cherniavskii/mui-x
1 participant
@cherniavskii