-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] New HTML legend & styles #15733
base: master
Are you sure you want to change the base?
Conversation
Deploy preview: https://deploy-preview-15733--material-ui-x.netlify.app/ |
@alexfauquette Do we still want to provide For |
For me the main reason is "It's easier to be consistent than to explain edge cases". For each slot "xxx" we provide What would be the issue with providing a |
@alexfauquette no specific reason, it was just a question that occurred to me 😅 I agree with your points 👍 |
I do think however, as we allow more customisation and hooks, we should drop |
I still see some interest to it. For example you use color scale and then need a special legend. It's nice to still have something like this instead of being forced to go full composition. <BarChart
{...my config}
slots={{ legend: ChartColorMapLegend }}
/> But yes it's something we could consider during the next major. Depending on the users feedback |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Testing code