[pickers] Add verification to disable skipped hours in spring forward DST #15849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
|
Deploy preview: https://deploy-preview-15849--material-ui-x.netlify.app/ |
flaviendelangle
changed the title
flaviendelangle
force-pushed
the
disable-spring-forward-dst-skipped-hours
branch
from
da45c2e to
0440c6f
Compare
flaviendelangle
commented
Dec 12, 2024
| @@ -316,6 +321,10 @@ export function Clock(inProps: ClockProps) { | |||
| } | |||
| }, [autoFocus]); | |||
|
|
|||
| const clampValue = (newValue: number) => Math.max(minViewValue, Math.min(maxViewValue, newValue)); | |||
There was a problem hiding this comment.
For the PageUp and PageDown we clamp the value (the min and max act as a boundary)
For the ArrowUp and ArrowDown we circle the value (when reaching the min, we go back to the max value and vice-versa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #15115
Closes #12403
I can't reproduce the bug in the tests 😢
Probably because the timezone is not the same...
I also noticed that in
TimeClock, thePageUp/PageDownnavigation could move outside of the displayed values, unlike theMultiSectionDigitalClock.For example when using meridiem, pressing
PageUpon the hour 8 PM would move you to the hour 1 AM, whereas on theMultiSectionDigitalClockit would move you to the hour 11 PM.This was causing a test to fail with the new DST check since we start checking if the expected hour was correct (and it was not).