Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Round dimensions to avoid subpixel rendering error #15850

Merged
merged 6 commits into from
Dec 13, 2024
Merged

[DataGrid] Round dimensions to avoid subpixel rendering error #15850

merged 6 commits into from
Dec 13, 2024
+32 −8

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Dec 11, 2024 •
edited
Loading

@KenanYusuf KenanYusuf added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Dec 11, 2024
@mui-bot
Copy link

mui-bot commented Dec 11, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15850--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5db24a7

@KenanYusuf KenanYusuf requested a review from a team December 11, 2024 15:20
@KenanYusuf KenanYusuf added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 11, 2024
@cherniavskii cherniavskii added regression A bug, but worse and removed bug 🐛 Something doesn't work labels Dec 11, 2024
MBilalShafi
MBilalShafi approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to add a test case for this one 👍

@KenanYusuf
Copy link
Member Author

I think the failing argos test is flaky, looks fine here https://codesandbox.io/p/sandbox/15850-loader-regression-test-cxv2kg

romgrk
romgrk requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one decimal place might be preferable, in some cases a subpixel value can make an actual rendering difference.

Screenshot From 2024-12-12 10-00-01

@KenanYusuf KenanYusuf merged commit 9720766 into mui:master Dec 13, 2024
18 checks passed
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@KenanYusuf @web-flow
[DataGrid] Round dimensions to avoid subpixel rendering error (#15850)
764f749
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@romgrk romgrk romgrk approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge regression A bug, but worse v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Maximum update depth exceeded - MUI Datagrid when renderCell is in columns
5 participants
@KenanYusuf @mui-bot @romgrk @MBilalShafi @cherniavskii