Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es512 Varsig codec name is incorrect #349

Closed
dhuseby opened this issue May 8, 2024 · 3 comments
Closed

es512 Varsig codec name is incorrect #349

dhuseby opened this issue May 8, 2024 · 3 comments

Comments

@dhuseby
Copy link
Contributor

dhuseby commented May 8, 2024

This is an error:

multicodec/table.csv

Line 540 in c954a78

es512, varsig, 0xd01202, draft, ES512 Signature Algorithm

The name should be es521 because this is an ECDSA signature using the P-521 curve.
@dhuseby dhuseby mentioned this issue May 8, 2024
Merged
@smoyer64
Copy link

ES512 is the correct algorithm name: https://datatracker.ietf.org/doc/html/rfc7518#section-3.1

@rvagg
Copy link
Member

rvagg commented Oct 14, 2024

So, named after the hash algorithm, so 512 is correct. Thanks for jumping in @smoyer64.

@rvagg rvagg closed this as completed Oct 14, 2024
@dhuseby
Copy link
Contributor Author

dhuseby commented Oct 31, 2024

Aha! Thanks for clarifying. That was confusing. Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smoyer64 @rvagg @dhuseby