Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet links with protocoltype mumble:// not working #5473

Closed
back2live opened this issue Jan 19, 2022 · 4 comments · Fixed by #5521
Closed

Internet links with protocoltype mumble:// not working #5473

back2live opened this issue Jan 19, 2022 · 4 comments · Fixed by #5521
Labels
bug A bug (error) in the software installer

Comments

@back2live
Copy link

back2live commented Jan 19, 2022

Description

After installation of Mumble on Windows the Internetshortcuts with mumble://my.url.to are not working

Steps to reproduce

  1. create a new shortcut with die destination to your mumbleserver for example mumble://my.url.to
  2. windows cant resolve mumble:// /protocoll "mumble" ist not linked to any Program"

Mumble version

No response

Mumble component

Client

OS

Windows

Reproducible?

Yes

Additional information

No response

Relevant log output

No response
mumble

@back2live back2live added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Jan 19, 2022
@Krzmbrzl Krzmbrzl added installer and removed triage This issue is waiting to be triaged by one of the project members labels Jan 19, 2022
@Krzmbrzl
Copy link
Member

We probably have to explicitly register ourselves as handler for that protocol when running the installer

@crazydisi
Copy link

Version 1.3.4 did the correct Registry entry the current versions seems to miss out on that one.

here is the export of the registry which is needed to make this functional again (default installation):

Windows Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\mumble]
@="URL:Mumble"
"URL Protocol"=""

[HKEY_CLASSES_ROOT\mumble\DefaultIcon]
@="C:\\Program Files\\Mumble\\client\\mumble.exe"

[HKEY_CLASSES_ROOT\mumble\shell]

[HKEY_CLASSES_ROOT\mumble\shell\open]

[HKEY_CLASSES_ROOT\mumble\shell\open\command]
@="C:\\Program Files\\Mumble\\client\\mumble.exe \"%1\""

@magneticflux-
Copy link
Contributor

Looks like the installer used to be configured to register it here:

mumble/installer/Files.wxs

Lines 106 to 109 in e799cc3

<RegistryValue Root="HKCR" Key="mumble" Value="URL:Mumble" Type="string" />
<RegistryValue Root="HKCR" Key="mumble" Name="URL Protocol" Value="" Type="string" />
<RegistryValue Root="HKCR" Key="mumble\DefaultIcon" Value="[#mumble.exe]" Type="string" />
<RegistryValue Root="HKCR" Key="mumble\shell\open\command" Value="[#mumble.exe] &quot;%1&quot;" Type="string" />

That file was removed by 88e1786. It seems like WixSharp should have some kind of analogue for the registry value addition.

@Krzmbrzl
Copy link
Member

Yes, the installer has been completely rewritten in WixSharp and I am sure there is a way to set this association within WixSharp as well - we simply forgot to do it.
Thanks for digging out the required configs, though.

magneticflux- added a commit to magneticflux-/mumble that referenced this issue Jan 26, 2022
…tall

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links.
This is a direct translation of `Files.wxs` to equivalent WixSharp code.

Closes mumble-voip#5473
magneticflux- added a commit to magneticflux-/mumble that referenced this issue Jan 26, 2022
…tall

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links.
This is a direct translation of `Files.wxs` to equivalent WixSharp code.

Closes mumble-voip#5473
magneticflux- added a commit to magneticflux-/mumble that referenced this issue Jan 26, 2022
…tall

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links.
This is a direct translation of `Files.wxs` to equivalent WixSharp code.

Closes mumble-voip#5473
magneticflux- added a commit to magneticflux-/mumble that referenced this issue Jan 26, 2022
…tall

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links.
This is a direct translation of `Files.wxs` to equivalent WixSharp code.

Closes mumble-voip#5473
magneticflux- added a commit to magneticflux-/mumble that referenced this issue Jan 26, 2022
…tall

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links.
This is a translation of the registry values from `Files.wxs` to equivalent WixSharp code.

Closes mumble-voip#5473
Krzmbrzl added a commit that referenced this issue Jan 27, 2022
…stry keys on install

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use mumble:// links.
This is a direct translation of Files.wxs to equivalent WixSharp code.

Closes #5473
Krzmbrzl pushed a commit to Krzmbrzl/mumble that referenced this issue Jan 27, 2022
…tall

In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links.
This is a translation of the registry values from `Files.wxs` to equivalent WixSharp code.

Closes mumble-voip#5473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (error) in the software installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants