FIX(installer): Re-add URL protocol registration registry keys on install #5521
Conversation
magneticflux-
force-pushed
the
master
branch
2 times, most recently
from
29986ae
to
1adcb95
Compare
|
Did you verify yet that this does indeed make the mumble-URLS work again? |
|
Well I borked my local build just as I thought I fixed it, so I'm trying to download the PR artifact, but that's not working now either. |
|
Looks like the File Table isn't being populated the same, so |
|
Okay, it builds, installs, and the registry keys work now! I just needed to add an explicit ID to the file. (The path is still the same, it just gives it a name in the File Table so other parts of the installer can reference it with |
|
Great! 👍 |
|
Should I also cherry-pick a backport PR to 1.4.x, or does that get done internally? |
|
I will do that once @ZeroAbility has reviewed this PR. I have an automation tool for that, so it's done very quickly. But thanks for the offer! |
There was a problem hiding this comment.
This is a direct translation of
Files.wxsto equivalent WixSharp code.
I would clarify this comment. It sounds like you added everything in the old WiX project instead of just adding the registry entries.
If the resulting installer works and the desired behavior occurs when clicking a URL, then I see no reason not to approve it.
…tall In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use `mumble://` links. This is a translation of the registry values from `Files.wxs` to equivalent WixSharp code. Closes mumble-voip#5473
|
I assume the registry keys created by the installer are automatically removed on uninstall, right? |
|
It might be worth it to review these: |
|
The installer should already track and remove the registry keys it creates (according to the Wix site here: https://wixtoolset.org/documentation/manual/v3/xsd/wix/registrykey.html). I think the "force" option is only needed if we want to remove something that wasn't put there by this installer. |
|
@magneticflux- Sometimes WiX is not as advertised, and they are not always very responsive when it comes to bugs. If you are able to just install Mumble fresh without the registry entry and do an uninstall to test removal of the registry entry, I think we would all consider that a sign off. |
ghost
assigned
|
@ZeroAbility Just confirmed that a fresh install and uninstall removes the registry keys. |
|
Thanks for fixing this 👍 |
In the installer refactor (88e1786) these registry keys were removed, so new installs did not register a URL protocol and users weren't able to use
mumble://links.This is a direct translation of
Files.wxsto equivalent WixSharp code.Closes #5473
Checks