-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make charts more abstract (more general properties), #22
Conversation
added much more options for chart labels/titles/Fonts, added chart.JS plugin reference for chart value labels (data labels), modified README.md
I've added much more things for options etc and a data label plugin for ChartJS (with modified README). In addition I made a base interface for the Chart objects to generalize the CanvasId and to implement an UpdateSize function for ALL charts without copying code everytime... And some other changes, have a look at the commit changes ^^ If something is wrong with my changes please do not hesitate to contact me ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some good progress. I just had a question about the usage of GetChart()
. I guess I don't understand what the usage is?
Isn't the chart object available already in the needed places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok for now. But my plan for future is that there should be a model or an extensibility endpoint so that people can write pure c# plugins and have that included with the component. I will start an issue and may be we can have more discussion about this over there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the test application with an example of changes as you did in the README. With that I think I will be glad to merge this!
Oh right, I will update the test project for better understanding, perhaps adding some comments here and there sould also not hurt :D |
removed unnecessary generic ChartJSChart.cs, added more comments
This is now merged. Thank you for the contribution. Much appreciated. Hopefully, this along with few other changes will get to the next nuget release along with Blazor updates. |
added much more options for chart labels/titles/Fonts,
added chart.JS plugin reference for chart value labels (data labels),
modified README.md