Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little bug in kamstrup usage simulator #543

Open
cancantian opened this issue Jan 22, 2021 · 1 comment
Open

little bug in kamstrup usage simulator #543

cancantian opened this issue Jan 22, 2021 · 1 comment

Comments

@cancantian
Copy link

def _get_energy_in_lowres(self):
return self.energy_in / 1000

def _get_energy_out_lowres(self):
    return self.energy_out / 1000

In Python 3 the / operator is a floating point division, // for integer division.
this will cause typeError in message.py
low_endian_value_packed.append(register_value & 0xFF)

@glaslos
Copy link
Member

glaslos commented Mar 1, 2021

@cancantian nice catch! Do you want to create a pull request to fix the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants