Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a feature to remove tanner-related sessions in redis-server on expiry #290

Open
viskey98 opened this issue Mar 1, 2019 · 3 comments

Comments

@viskey98
Copy link
Collaborator

viskey98 commented Mar 1, 2019

Lately we have been facing a problem on the snare side (mushorg/snare#180) due to default-tanner.
According to @afeena it occurred because there are lot of sessions in the redis-server database which has consumed almost the complete memory capacity. This is because of the low memory of our default tanner server (Obviously it wasn't meant for production purpose). Due to this snare sessions were unable to be processed and stored in the same.

This gave me a thought, what if we build a new feature :

  • Requires a new config parameter expiry_time to be present in tanner.config.
  • Use it to delete (tanner-created) sessions from redis-server after that 'expiry_time`.
  • And this expiry_time can be configured based on the server-admin, depending on the duration of the history of data required and depending on the memory capacity of the server.
  • The deletion can be done periodically or in a lazy fashion depending on the implementation.

This is just a thought, looking for others opinions on the same :)

@rnehra01
Copy link
Collaborator

rnehra01 commented Mar 1, 2019

Yeah, I think auto-deleting based on memory is kinda must as we won't do that then it will just stop working.

@amanjiofficial
Copy link

What period would be suitable for deletion @viskey98 @rnehra01

@rnehra01
Copy link
Collaborator

It's good to keep the period as parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants