Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: background audio handling #1251

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: background audio handling #1251

wants to merge 16 commits into from

Conversation

SputNikPlop
Copy link
Collaborator

This should better handle the audio while tts is on, should be tested though.

@kevmo314
Copy link
Contributor

Superficially this seems reasonable but I think we should launch the new TTS engine before getting this in. This adds a good amount of complexity and it would be better to simplify TTS and get the new engine out before making it more complex.

@SputNikPlop
Copy link
Collaborator Author

Superficially this seems reasonable but I think we should launch the new TTS engine before getting this in. This adds a good amount of complexity and it would be better to simplify TTS and get the new engine out before making it more complex.

Got it, there also is a slight difference between 19ba377 and c1444cd on the audio it seems so later that will have to be sorted to which version is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmo314 kevmo314 Awaiting requested review from kevmo314

@juaoose juaoose Awaiting requested review from juaoose

@chungwwei chungwwei Awaiting requested review from chungwwei

@cswills cswills Awaiting requested review from cswills

@jessielw jessielw Awaiting requested review from jessielw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SputNikPlop @kevmo314