Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makes configuration at environment group level for multiple apps… #110

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

fritzduchardt
Copy link
Collaborator

… installed to the same environment possible. Does so, by using the directory structure in the "prototypes" folder to look for helm and ytt configuration at env group level.

closes #109

Copy link
Member

@Zebradil Zebradil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the problem in #109

internal/myks/render_ytt.go Outdated Show resolved Hide resolved
@fritzduchardt
Copy link
Collaborator Author

@Zebradil I have had another stab at this feature. I have now added the extension of prototypes at environment group level with a folder called _proto. This can be used optionally on top of the existing extension with _app whereby _app wins if both are being used.

The new integration test setup is great. Thanks @kbudde .

… installed to the same environment possible. Does so, by using the directory structure in the "prototypes" folder to look for helm and ytt configuration at env group level.
@fritzduchardt fritzduchardt force-pushed the fix/env-group-conundrum branch from e378947 to fb25345 Compare November 26, 2023 16:22
@Zebradil Zebradil merged commit a7c5188 into dev Dec 4, 2023
5 checks passed
@Zebradil Zebradil deleted the fix/env-group-conundrum branch December 4, 2023 07:52
@Zebradil Zebradil mentioned this pull request Dec 4, 2023
Zebradil pushed a commit that referenced this pull request Dec 4, 2023
Makes configuration at environment group level for multiple apps
installed to the same environment possible. Does so, by using the
directory structure in the "prototypes" folder to look for helm and ytt
configuration at env group level.

closes #109
mykso-bot added a commit that referenced this pull request Dec 11, 2023
# [2.2.0](v2.1.1...v2.2.0) (2023-12-11)

### Features

* implement prototype overwrites in the envs tree ([#110](#110)) ([c3e550d](c3e550d)), closes [#109](#109)
* include namespace in output file name ([#141](#141)) ([42fa566](42fa566))
* new plugin for copying static files ([#132](#132)) ([0f7c9dc](0f7c9dc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Allow prototypes to inherit
2 participants