feat: embed ytt #272
Merged
feat: embed ytt #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zebradil
approved these changes
Apr 20, 2024
|
Nice 👍 For tests, we can use a script which builds a new myks binary from the current state and adds it into PATH.
I think yes, why not? In the future, we can change to run it as a library rather than as a standalone process. |
|
I have added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
myksbinary which was called to render; before it was the firstmyksin PATH which could have a different vendir/ytt versionStill an issue: While running
go testa test binary is created which is not providing the embedded sub commands. Fallback to "myks" command in path (as before).Question: Do we want to embedd ytt as well? If not, I would update the PR to only include the fix.