[Brent] Add payment for some containers. #5274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5274 +/- ##
==========================================
+ Coverage 82.35% 82.37% +0.02%
==========================================
Files 413 413
Lines 32668 32683 +15
Branches 5236 5240 +4
==========================================
+ Hits 26903 26922 +19
+ Misses 4216 4212 -4
Partials 1549 1549 ☔ View full report in Codecov by Sentry. |
dracos
force-pushed
the
4589-brent-charging-containers
branch
from
bbb3f90
to
938046c
Compare
| @@ -54,14 +54,21 @@ sub council_area { return 'Brent'; } | |||
| sub council_name { return 'Brent Council'; } | |||
| sub council_url { return 'brent'; } | |||
|
|
|||
| Readonly::Scalar my $CONTAINER_GREY_BIN => 16; | |||
There was a problem hiding this comment.
What's the upside to using Readonly::Scalar versus 'use constant'? I haven't come across Readonly often.
There was a problem hiding this comment.
Yeah, the main advantage here is that use constant constants can't be used as keys in hashes, see https://metacpan.org/pod/Readonly#Comparison-with-%22use-constant%22
| Readonly::Scalar my $CONTAINER_FOOD_CADDY => 11; | ||
| Readonly::Scalar my $CONTAINER_GREEN_BIN => 13; | ||
| Readonly::Scalar my $CONTAINER_BLUE_SACK => 46; | ||
|
|
||
| my $BRENT_CONTAINERS = { | ||
| 1 => 'Blue rubbish sack', |
There was a problem hiding this comment.
Has 1 been left alone because it's not currently used anywhere else?
There was a problem hiding this comment.
Yeah, I wasn't sure if it should actually be removed, but this halfway house seemed easiest :)
[skip changelog] Fixes https://github.com/mysociety/societyworks/issues/4589
(changes from WIP. -I moved the set up of payment into the about_you next because in the replacement next we don’t yet have the answer to the “how_long_lived” question, and I don’t think we need a special page about payment, they can stick whatever text they want in the intro)