Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for switching to userlad module after Node deprecation no-deprecated-api #72

Closed
corbinu opened this issue Mar 22, 2017 · 2 comments
Labels

Comments

@corbinu
Copy link

corbinu commented Mar 22, 2017

So I added the punycode module to fix the fact that it is deprecated in Node v7 but I still get the error

error  'punycode' module was deprecated since v7. Use 'https://www.npmjs.com/package/punycode' instead  node/no-deprecated-api
@mysticatea
Copy link
Owner

Thank you for this issue.

However, third party modules don't hide core modules, so you are still using the deprecated core module.
See also: #69

@corbinu corbinu changed the title False error on no-deprecated-api when punycode is in dependancies Better error message for switching to userlad module after Node deprecation no-deprecated-api Mar 23, 2017
@corbinu
Copy link
Author

corbinu commented Mar 23, 2017

Ok thanks I changed the issue accordingly ... though I am still wondering if it is technically an error given that let's say Node v9 drops punycode. Now that I have added it to the deps my app should just keep working. For some that may be the expected behavior. However I think documenting the need for the trailing slash works too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants