Fix: README etc. are only assumed published if in pkg root (fixes #73) #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements one of the approaches I outlined in issue #73 to ensure that files like
test/readme.js
(has a basename equal to something that npm auto-publishes, but is not in the package root) are not treated as published and so can require devDependencies.Specifically, when using the NEVER_IGNORED regex, this PR will pass the full relative path from package root to the linted file, instead of the linted file's basename. All existing tests pass with this logic, and my new tests also pass (but failed with the old logic).
Please let me know if I should make any changes.