refactor(iroh-net): small improvements to dns code #2301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
collect
in dns lookups.TryParseIp
bound on lookup functions.strategy that would naturally fit this use.
Breaking Changes
iroh_net::dns::lookup_ipv4_ipv6
is removed in favor ofiroh_net::dns::ResolverExt::lookup_ipv4_ipv6
Notes & open questions
Was
iroh_net::dns::lookup_ipv4_ipv6
meant to be part of the public api? I don't really see why.Change checklist
Tests if relevant.