examples: minimize use of raw base32 in examples #2304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that in the example code (particularly
iroh-net
's code), there are a few explicit uses ofbase32
encoding and decoding that are unnecessary. In particular,SecretKey
is manuallybase32
-encoded in the networking examples, although theDisplay
implementation uses that same encoding. I figure that the examples were just written before the utility encoding/decoding code in the main libraries were and weren't updated when that utility code was added. I hope that catching this is helpful!Breaking Changes
None.
Notes & open questions
None.
Change checklist