Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: minimize use of raw base32 in examples #2304

Merged

Conversation

marceline-cramer
Copy link
Contributor

Description

I noticed that in the example code (particularly iroh-net's code), there are a few explicit uses of base32 encoding and decoding that are unnecessary. In particular, SecretKey is manually base32-encoded in the networking examples, although the Display implementation uses that same encoding. I figure that the examples were just written before the utility encoding/decoding code in the main libraries were and weren't updated when that utility code was added. I hope that catching this is helpful!

Breaking Changes

None.

Notes & open questions

None.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, those examples were probably written before we had all these niceties :)

@dignifiedquire dignifiedquire enabled auto-merge May 16, 2024 18:49
@dignifiedquire dignifiedquire changed the title chore: minimize use of raw base32 in examples examples(iroh-net): minimize use of raw base32 in examples May 16, 2024
@dignifiedquire dignifiedquire changed the title examples(iroh-net): minimize use of raw base32 in examples examples: minimize use of raw base32 in examples May 16, 2024
@dignifiedquire dignifiedquire added this pull request to the merge queue May 16, 2024
Merged via the queue into n0-computer:main with commit 1fafc9e May 16, 2024
24 checks passed
@marceline-cramer marceline-cramer deleted the cleanup-example-base32 branch May 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants