-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Postgres Node): Special datetime values cause errors #11225
Merged
elsmr
merged 3 commits into
master
from
node-1245-postgres-special-datetime-values-cause-errors
Oct 22, 2024
Merged
fix(Postgres Node): Special datetime values cause errors #11225
elsmr
merged 3 commits into
master
from
node-1245-postgres-special-datetime-values-cause-errors
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Oct 11, 2024
elsmr
reviewed
Oct 11, 2024
include valid date check Co-authored-by: Elias Meire <[email protected]>
ShireenMissi
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
n8n Run #7477
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1245-postgres-special-datetime-values-cause-errors
|
Run status |
Passed #7477
|
Run duration | 04m 22s |
Commit |
0ccff01df8: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
|
Committer | Elias Meire |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
0
|
Skipped |
0
|
Passing |
458
|
View all changes introduced in this branch ↗︎ |
elsmr
approved these changes
Oct 22, 2024
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1245-postgres-special-datetime-values-cause-errors
branch
October 22, 2024 10:02
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
n8n team
Authored by the n8n team
node/improvement
New feature or request
Released
tests-needed
This PR needs additional tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Postgres Node uses the pg module to parse the postgres query response. However, this would fail for some special datetime values in postgres, e.g.
infinity
, and throw an error"Invalid time value"
.This PR adds a check to catch these and return them unparsed.
Since the modified parse function is only for
TIMESTAMP
orTIMESTAMPTZ
values, the only other possible edge case would benull
, which is returned correctly. The test table covers that.To Test:
Related Linear tickets, Github issues, and Community forum posts
Invalid time value
error if timestamp column contains special datetime values #8912Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)