Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Ensure toasts show above modal overlays #11410

Merged
merged 9 commits into from
Oct 25, 2024
Merged

fix(editor): Ensure toasts show above modal overlays #11410

merged 9 commits into from
Oct 25, 2024

Conversation

mutdmour
Copy link
Contributor

Summary

Ensure notifications show above modal overlays
Screenshot 2024-10-25 at 11 54 09

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 25, 2024
@mutdmour mutdmour marked this pull request as ready for review October 25, 2024 10:29
netroy
netroy previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

packages/editor-ui/src/composables/useStyles.ts Show resolved Hide resolved
packages/editor-ui/src/composables/useStyles.ts Show resolved Hide resolved
@mutdmour
Copy link
Contributor Author

@netroy can you please review again? Should be ready now 🤞🏽

@mutdmour mutdmour requested a review from netroy October 25, 2024 14:38
netroy
netroy approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@netroy netroy changed the title fix: Ensure toasts show above modal overlays fix(editor): Ensure toasts show above modal overlays Oct 25, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 25, 2024 •
edited
Loading

n8n    Run #7581

Run Properties:  status check passed Passed #7581  •  git commit 351134f786: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #7581
Run duration 04m 22s
Commit git commit 351134f786: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 459
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 351134f into master Oct 25, 2024
34 checks passed
@mutdmour mutdmour deleted the ado-2583 branch October 25, 2024 14:56
This was referenced Oct 28, 2024
Closed
Merged
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

@MiloradFilipovic MiloradFilipovic Awaiting requested review from MiloradFilipovic

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @netroy