Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user if pickle is requested but the pickled file is older. #4

Open
cuantar opened this issue Nov 29, 2022 · 3 comments · Fixed by #3
Open

Warn the user if pickle is requested but the pickled file is older. #4

cuantar opened this issue Nov 29, 2022 · 3 comments · Fixed by #3
Labels
discussed Discussed during a NANOGrav GitFlowers Meeting. enhancement New feature or request help wanted Extra attention is needed

Comments

@cuantar
Copy link
Collaborator

cuantar commented Nov 29, 2022

Whenever usepickle = True is set, the pickled version of a *.tim file will always be used. Consequently, forgetting that the pickled version is in use and then making changes to the *.tim file leads to confusion when the output does not change.

When the pickle file has been modified less recently than the *.tim file for which it can substitute, a helpful advisory message should be produced so that the current state of the program cannot be overlooked easily.

@cuantar
Copy link
Collaborator Author

cuantar commented Nov 29, 2022

... it's not the *.tim fle that needs to be checked; it is the config file.

@cuantar cuantar added the enhancement New feature or request label Nov 29, 2022
@cuantar cuantar linked a pull request Nov 29, 2022 that will close this issue
@cuantar
Copy link
Collaborator Author

cuantar commented Nov 29, 2022

the warning should not seem dire and scare newbies

@cuantar cuantar reopened this Dec 1, 2022
@JPGlaser JPGlaser added help wanted Extra attention is needed discussed Discussed during a NANOGrav GitFlowers Meeting. labels May 30, 2024
@rossjjennings
Copy link
Member

This could still be fixed, but we discussed it at a git-flowers meeting and decided that the old PR was too different from the current state of the code, and it would be better to open a new PR based on the current code instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussed Discussed during a NANOGrav GitFlowers Meeting. enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
3 participants