Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REQ should fast fail if retry timer is zero (on disconnect) #1300

Closed
gdamore opened this issue Oct 9, 2020 · 0 comments
Closed

REQ should fast fail if retry timer is zero (on disconnect) #1300

gdamore opened this issue Oct 9, 2020 · 0 comments
Assignees
@gdamore
Milestone
v1.4

Comments

@gdamore
Copy link
Contributor

gdamore commented Oct 9, 2020

This is a request for equivalent functionality to nanomsg/mangos#218

Basically, if we encounter a disconnect after sending a message, if we're not going to replay the message (retry timer is zero), then we should just go ahead and fail the message right away; there is no point in waiting for a longer receive timer to fire out, especially as the receive timeout could be rather longish.
@gdamore gdamore added this to the v1.4 milestone Oct 27, 2020
@gdamore gdamore self-assigned this Oct 31, 2020
gdamore added a commit that referenced this issue Oct 31, 2020
@gdamore
fixes #1300 REQ should fast fail if retry timer is zero (on disconnect)
520d017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
1 participant
@gdamore