-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate cobra's v2 bash completions #141
Conversation
Inhibiting descriptions for consistency with fish completions. Ref https://github.com/spf13/cobra/blob/main/site/content/completions/_index.md#bash-completion-v2
WalkthroughThe recent update enhances the command-line interface (CLI) completion functionality by transitioning from the older Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- cmd/completion.go (1 hunks)
- internal/completion/completion.go (2 hunks)
Additional comments not posted (3)
cmd/completion.go (1)
28-28
: The update toGenBashCompletionV2
aligns with the PR's objectives. Please ensure thefalse
argument is used as intended according to Cobra's documentation.internal/completion/completion.go (2)
39-39
: Update toGenBashCompletionV2
is consistent with the PR's objectives. Ensure robust error handling and correct usage of thefalse
argument.
170-170
: The update toGenBashCompletionV2
for content comparison is appropriate. Verify the comparison logic's effectiveness with the new completion version.
Wow, thanks for the PR! |
Inhibiting descriptions for consistency with fish completions.
Ref https://github.com/spf13/cobra/blob/main/site/content/completions/_index.md#bash-completion-v2
Summary by CodeRabbit