* added option to exclude binaries from gup update #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nao1215
requested changes
Apr 30, 2023
Comment on lines
+91
to
+101
| func excludePkgs(exclude string, pkgs []goutil.Package) []goutil.Package { | ||
| excludelist := strings.Split(exclude, ",") | ||
|
|
||
| for i := len(pkgs) - 1; i >= 0; i-- { | ||
| if slice.Contains(excludelist, pkgs[i].Name) { | ||
| pkgs = append(pkgs[:i], pkgs[i+1:]...) | ||
| } | ||
| } | ||
|
|
||
| return pkgs | ||
| } |
There was a problem hiding this comment.
I would like to make a small modification. The code you wrote uses less memory. However, The following writing style is simpler and easier to read.
Suggested change
| func excludePkgs(exclude string, pkgs []goutil.Package) []goutil.Package { | |
| excludelist := strings.Split(exclude, ",") | |
| for i := len(pkgs) - 1; i >= 0; i-- { | |
| if slice.Contains(excludelist, pkgs[i].Name) { | |
| pkgs = append(pkgs[:i], pkgs[i+1:]...) | |
| } | |
| } | |
| return pkgs | |
| } | |
| func excludePkgs(exclude string, pkgs []goutil.Package) []goutil.Package { | |
| excludeList := strings.Split(exclude, ",") | |
| packageList := []goutil.Package{} | |
| for _, v := range pkgs { | |
| if slice.Contains(excludeList, v.Name) { | |
| continue | |
| } | |
| packageList = append(packageList, v) | |
| } | |
| return pkgs | |
| } |
nao1215
requested changes
Apr 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 83.28% 82.79% -0.49%
==========================================
Files 15 15
Lines 676 686 +10
==========================================
+ Hits 563 568 +5
- Misses 82 87 +5
Partials 31 31
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nao1215
reviewed
May 1, 2023
| @@ -32,6 +33,7 @@ under $GOPATH/bin and automatically updates commands to the latest version.`, | |||
| } | |||
| cmd.Flags().BoolP("dry-run", "n", false, "perform the trial update with no changes") | |||
| cmd.Flags().BoolP("notify", "N", false, "enable desktop notifications") | |||
| cmd.Flags().StringP("exclude", "e", "", "specify binaries which should not be updated separated using ',' without spaces as a delimiter") | |||
There was a problem hiding this comment.
Wouldn't it be more convenient to use StringSliceP() instead of StringP() for this code?
https://pkg.go.dev/github.com/spf13/pflag#StringSliceP
There was a problem hiding this comment.
I might be better, I just never used cobra and didn't take the time to read through the docu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.