-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for null in DuplicateAction #6904
Check for null in DuplicateAction #6904
Conversation
Note this is tough to create an automated test for in that I can't figure out how to create a Display Layout with a |
Current Playwright Test Results Summary✅ 134 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/09/2023 06:38:03pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2 • Retry 1 • Initial Attempt |
12.80% (16)16 / 125 runsfailed over last 7 days |
29.60% (37)37 / 125 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 103 runsfailed over last 7 days |
30.10% (31)31 / 103 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 135 runsfailed over last 7 days |
37.04% (50)50 / 135 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/09/2023 06:38:03pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 5029ecd
Started: 08/09/2023 05:18:10pm UTC
Codecov Report
@@ Coverage Diff @@
## master #6904 +/- ##
==========================================
- Coverage 46.00% 42.03% -3.98%
==========================================
Files 643 410 -233
Lines 25627 12688 -12939
Branches 2496 0 -2496
==========================================
- Hits 11790 5333 -6457
+ Misses 13362 7355 -6007
+ Partials 475 0 -475
*This pull request uses carry forward flags. Click here to find out more.
... and 446 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@scottbell double checked and works against the original issue filed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
check for null before checking before hasOwnProperty
check for null before checking before hasOwnProperty Co-authored-by: Scott Bell <[email protected]>
Closes #6900
Describe your changes:
Check for
null
orundefined
beforehasOwnProperty
to prevent exception from being thrown onnull
valued properties.All Submissions:
Author Checklist
Reviewer Checklist