Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for null in DuplicateAction #6904

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Aug 9, 2023

Closes #6900

Describe your changes:

Check for null or undefined before hasOwnProperty to prevent exception from being thrown on null valued properties.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Aug 9, 2023 that may be closed by this pull request
7 tasks
@scottbell
Copy link
Contributor Author

Note this is tough to create an automated test for in that I can't figure out how to create a Display Layout with a null height or width. I suspect the null value was fixed in this PR.

@deploysentinel
Copy link

deploysentinel bot commented Aug 9, 2023

Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/09/2023 06:38:03pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 5029ecd

Started: 08/09/2023 06:32:20pm UTC

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2Retry 1Initial Attempt
12.80% (16) 16 / 125 runs
failed over last 7 days
29.60% (37) 37 / 125 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 103 runs
failed over last 7 days
30.10% (31) 31 / 103 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 135 runs
failed over last 7 days
37.04% (50) 50 / 135 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/09/2023 06:38:03pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 5029ecd

Started: 08/09/2023 05:18:10pm UTC

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #6904 (26afab4) into master (58aeac9) will decrease coverage by 3.98%.
The diff coverage is n/a.

❗ Current head 26afab4 differs from pull request most recent head 5029ecd. Consider uploading reports for the commit 5029ecd to get more accurate results

@@            Coverage Diff             @@
##           master    #6904      +/-   ##
==========================================
- Coverage   46.00%   42.03%   -3.98%     
==========================================
  Files         643      410     -233     
  Lines       25627    12688   -12939     
  Branches     2496        0    -2496     
==========================================
- Hits        11790     5333    -6457     
+ Misses      13362     7355    -6007     
+ Partials      475        0     -475     
Flag Coverage Δ *Carryforward flag
e2e-full 42.03% <ø> (ø) Carriedforward from 1e3097f
e2e-stable ?
unit ?

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/duplicate/DuplicateTask.js 0.00% <ø> (-97.76%) ⬇️

... and 446 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58aeac9...5029ecd. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 9, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 9, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 9, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 9, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 9, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 9, 2023
@unlikelyzero
Copy link
Collaborator

@scottbell double checked and works against the original issue filed

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx added this to the Target:3.0.1 milestone Aug 9, 2023
@ozyx ozyx enabled auto-merge (squash) August 9, 2023 18:30
@ozyx ozyx merged commit 9be9c5e into master Aug 9, 2023
11 checks passed
@ozyx ozyx deleted the 6900-duplicate-action-does-not-work-on-some-objects branch August 9, 2023 18:38
ozyx pushed a commit that referenced this pull request Aug 9, 2023
check for null before checking before hasOwnProperty
ozyx added a commit that referenced this pull request Aug 9, 2023
check for null before checking before hasOwnProperty

Co-authored-by: Scott Bell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Action does not work on some objects
3 participants