Refactor: obsolete throwOnUnexpectedArg in favor of UnrecognizedArgumentHandling enum #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 9, 2020
natemcmaster
force-pushed
the
throw-unexpected-args
branch
from
f88fad8 to
238a068
Compare
natemcmaster
force-pushed
the
throw-unexpected-args
branch
from
238a068 to
42b8994
Compare
This was referenced Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
What
Adds new API, UnrecognizedArgumentHandling, that I think is a better name for the behavior. It also allows room to add new ways to handle unrecognized arguments.
Why
This is a common pitfall of using this library. It's legacy API from the original fork of this code, and it's not possible to get rid of it easily. So, this is phase 1 = obsolete it in 2.6. Phase 2 = delete it for the 3.0 release.