Ignoring a FileNotFound excpetion that can bring down a supervisor. #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be better to catch and suppress FileNotFoundExceptions in rmpath itself? The ultimate goal of the function is to ensure that path is deleted, so it's fine to suppress that error. |
|
Will do. |
nathanmarz
added a commit
that referenced
this pull request
Sep 19, 2013
Ignoring a FileNotFound excpetion that can bring down a supervisor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests we found a race. kill_local_storm_cluster in testing.clj tries to shut down the supervisor and kill all running workers using try_worker_cleanup. At the same time a worker may have exited and the sync_process would also call try_worker_cleanup. The last one called gets a FileNotFoundException from the call to rmr. rmr can also throw an IOException if there are other issues with deleting the directory. I thought it was best just to ignore this error like we do RuntimeExceptions thrown by rmpath.