Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes build_release.sh issue when using leiningen v2.3 #670

Merged
merged 1 commit into from
Aug 29, 2013

Conversation

jasonjckn
Copy link
Collaborator

latest version of leiningen breaks bin/build_release.sh creating zip without jar files. This fixes it by forcing lein to store jar in the same path it use to, target/... instead of target/profile-name/...

Steps to reproduce:

  1. invoke bin/build_release.sh with leiningen version = 2.3.2+, you will see the zip file does not contain any jars.

@nathanmarz
Copy link
Owner

If it's backwards compatible let's take out the min-lein-version

@jasonjckn
Copy link
Collaborator Author

@nathanmarz Done.

Tested on leiningen v2.3.2 and v2.2.0

…without jar files. This fixes it by forcing lein to store jar in the same path it use to, target/... instead of target/profile-name/...
@jasonjckn
Copy link
Collaborator Author

Fyi, my Author changed Author: Jason Jackson [email protected]
Not sure if you care

@jasonjckn
Copy link
Collaborator Author

it's a pain in my setup to flip these back and forth.

nathanmarz added a commit that referenced this pull request Aug 29, 2013
Fixes build_release.sh issue when using leiningen v2.3
@nathanmarz nathanmarz merged commit 6f7ed1e into nathanmarz:master Aug 29, 2013
@jasonjckn
Copy link
Collaborator Author

@nathanmarz I find the git history to be not so useful.
commit cdbdf8d
Author: Jake Donham [email protected]
Date: Mon Aug 26 14:08:36 2013 -0700

oops

commit 85895c8
Author: Jake Donham [email protected]
Date: Mon Aug 26 14:07:01 2013 -0700

unique URLs in findAndReadConfigFile to work around apparent sbt/nsc bug where the same resource is returned more than once

commit 46cc0fc
Author: Jake Donham [email protected]
Date: Mon Aug 26 14:01:08 2013 -0700

make FixedTupleSpout implement IRichSpout so it can be used for tests

If you asked people to rebase their commits before merging it would clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants