Add in the ability to configure the number of worker threads for Netty... #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y messaging, and set up some reasonable defaults for Netty.
|
+1. I think this can go into 0.9.0 too. |
|
+1 |
|
+1 for 0.9.0 |
ptgoetz
added a commit
that referenced
this pull request
Oct 7, 2013
Add in the ability to configure the number of worker threads for Netty...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and set up some reasonable defaults for Netty.
In trying to find a good set of defaults for Netty I discovered that using the default number of worker threads caused a lot of contention due to excess context switching. This patch adds in the ability to configure the number of worker threads Netty uses and sets some reasonable defaults that for my tests let Netty send between 40% and 110% more messages per second than zeromq.
This does not enable Netty by default, it just adds default configurations for when Netty is configured.