From 54b36c744c2dacf3011971d779bca968f9c157ac Mon Sep 17 00:00:00 2001
From: Sergej Sakac <73715684+Szegoo@users.noreply.github.com>
Date: Sat, 8 Apr 2023 20:20:13 +0300
Subject: [PATCH] Warn if pallet provided to try-state does not exist (#13858)

* Warn if pallet does not exist in try-state

* unwrap_or_default
---
 frame/support/src/traits/try_runtime.rs | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/frame/support/src/traits/try_runtime.rs b/frame/support/src/traits/try_runtime.rs
index 6103f07a73c78..bebc248721c99 100644
--- a/frame/support/src/traits/try_runtime.rs
+++ b/frame/support/src/traits/try_runtime.rs
@@ -168,11 +168,19 @@ impl<BlockNumber: Clone + sp_std::fmt::Debug + AtLeast32BitUnsigned> TryState<Bl
 					#( (<Tuple as crate::traits::PalletInfoAccess>::name(), Tuple::try_state) ),*
 				)];
 				let mut result = Ok(());
-				for (name, try_state_fn) in try_state_fns {
-					if pallet_names.iter().any(|n| n == name.as_bytes()) {
+				pallet_names.iter().for_each(|pallet_name| {
+					if let Some((name, try_state_fn)) =
+						try_state_fns.iter().find(|(name, _)| name.as_bytes() == pallet_name)
+					{
 						result = result.and(try_state_fn(n.clone(), targets.clone()));
+					} else {
+						crate::log::warn!(
+							"Pallet {:?} not found",
+							sp_std::str::from_utf8(pallet_name).unwrap_or_default()
+						);
 					}
-				}
+				});
+
 				result
 			},
 		}