Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max History Per Key hard limit in KeyValue store #3465

Closed
andrea-tomassi opened this issue Sep 10, 2022 · 5 comments
Closed

Max History Per Key hard limit in KeyValue store #3465

andrea-tomassi opened this issue Sep 10, 2022 · 5 comments

Comments

@andrea-tomassi
Copy link

Feature Request

According to current specs "Max History Per Key cannot be more than 64".

Is there any tech constraint for such a low number?

Use Case:

Any with a need for an higher history

Proposed Change:

unlock the max-history value and allow reading recent history only by selecting the last number of items/by date
e.g. nc.keyValue(storeName).history("store-name", 10) should return the lastest 10 items from history

Who Benefits From The Change(s)?

Alternative Approaches

@derekcollison
Copy link
Member

I think this is a Go client, and other client limitation, not a server one IIRC.

@derekcollison
Copy link
Member

Believe Go client relaxed this.

@solita-cristian
Copy link

This is still the case for both NATS client and server libraries 🤔

@derekcollison
Copy link
Member

This is not enforced by the server, this is a client side thing. @Jarema

@Jarema
Copy link
Member

Jarema commented Aug 11, 2023

This is being discussed here nats-io/nats.go#1365 and as @derekcollison mentioned, we only need to change it on client side. This ticket should remain closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants