Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on PullConsumeOpt and PullMessagesOpt is not clear #1756

Open
ohler55 opened this issue Dec 17, 2024 · 1 comment
Open

Documentation on PullConsumeOpt and PullMessagesOpt is not clear #1756

ohler55 opened this issue Dec 17, 2024 · 1 comment
Assignees
Labels
defect Suspected defect such as a bug or regression

Comments

@ohler55
Copy link

ohler55 commented Dec 17, 2024

Observed behavior

PullConsumeOpt and PullMessagesOpt interfaces includes not only functions such as ConsumeErrHandler() but also some undocumented options such as the StopAfter type. The documentation on the StopAfter type indicated it sets the number of messages but it does not indicated how or what is needed to do that. The same is true of the following:

  • PullExpiry
  • PullMaxBytes
  • PullHeartbeat
  • PullMaxMessages
  • PullThresholdBytes
  • PullThresholdMessages

Expected behavior

I would expect the documentation for each type to include a statement that is implements the PullConsumeOpt interface or which ever interfaces it implements as related to the API.

Server and client version

https://pkg.go.dev/github.com/nats-io/nats.go/jetstream v1.37.0

Host environment

Any browser on any platform.

Steps to reproduce

Access the https://pkg.go.dev/github.com/nats-io/nats.go/jetstream page.

@ohler55 ohler55 added the defect Suspected defect such as a bug or regression label Dec 17, 2024
@piotrpio piotrpio self-assigned this Dec 18, 2024
@piotrpio
Copy link
Collaborator

Hello @ohler55, thank you for submitting the issue! I agree, the documentation for those options is lacking, I'll update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

No branches or pull requests

3 participants