Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of this implementation #34

Open
Guptajakala opened this issue Sep 28, 2020 · 0 comments
Open

Explanation of this implementation #34

Guptajakala opened this issue Sep 28, 2020 · 0 comments

Comments

@Guptajakala
Copy link

Hi, thanks for the great repo! I'm interested in finetuning the model for my research and I'm trying to understand your implementation here:

scale = np.sqrt(np.clip(np.abs(dx[1]*dy[0] - dx[0]*dy[1]), 1e-16, 1e16))

  1. what is this line doing?

  2. From the comments above, it says "applying a median filter" but I didn't see median filter afterwards. Is this comment deprecated?

  3. for _ in range(50*self.n_samples):
    Seems here you are doing some window selection based on best optical flow quality. Is this part necessary? Does it make big difference compared with random sampling a valid window inside the image region (without score comparison)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant