-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce pwa configs #323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@erditkurteshiSQA Thanks for finding and fixing the async error in that fetch function. This PR is much closer now. I'll spend some time post-nearcon to optimize which files are cached, to ensure that the complied js is not cached, otherwise it will conflict with newly released components and dependencies. |
Sounds good, let me know if you need anything else from my side on this one. |
… discovery is saved on mobile browsers
@heycorwin @vanessadespain please checkout this preview build. This PR tells a browser client that near.org is an installable app. You should notice the download icon in the right side of your browser's URL field. I've used |
thanks @vanessadespain i've updated it to match our website's current tag Once you install the app. Try to search for it, open it, close it, etc. As you would another installed app like safari. |
@vanessadespain dark/light support for PWAs has not yet been formalized and is still under consideration. We'll have to revisit this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I installed the pwa on my device using the vercel link and the icon is a black square. Additionally the home page when not logged in is the near social feed, but that may be intentional?
thanks for testing @jackson-harris-iii Could you also try to enable push notifications on your mobile client and see if they are flowing correctly? |
I was able to receive notifications, but did have some intermittent strange behavior.
|
really appreciate your help testing @jackson-harris-iii, thanks.
Thanks for calling out that the logged-out experience drops you into the activity feed. I'm going to push a couple updates to test options with multiple shortcut links. |
… better pnpm dev performance
…non-critical attributes
Glad to help @charleslavon!
|
This PR introduces a new dependency, next-pwa, for some baseline caching configs with a service worker that regenerates upon each next build. The goal is to support a more native app feel for near.org.
With improved caching of static resources for an increased level of functionality when dropping in an out of network connectivity, and supporting a browser's default ability to prompt a user to install the app to their home screen.