Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Show transaction fees on TX Detail page #124

Closed
3 tasks done
kcole16 opened this issue Nov 13, 2019 · 8 comments · Fixed by #213
Closed
3 tasks done

Show transaction fees on TX Detail page #124

kcole16 opened this issue Nov 13, 2019 · 8 comments · Fixed by #213
Assignees

Comments

@kcole16
Copy link
Contributor

kcole16 commented Nov 13, 2019

Story

As a user, I want to view the transaction fees for a given transaction, so I can better understand my costs and NEAR's economics.

Acceptance Criteria

  • Total Gas Cost (gas used * gas price)
  • Gas Units Used (units of gas)
  • Gas Unit Price (price per unit in NEAR) Ⓝ
@frol
Copy link
Collaborator

frol commented Dec 6, 2019

Fees are not exposed via RPC for individual transactions just yet (near/nearcore#1299), so this issue is blocked by nearcore.

@icerove
Copy link
Contributor

icerove commented Dec 6, 2019

got it

@kcole16 kcole16 added the blocked needs something from nearcore label Jan 14, 2020
@kcole16 kcole16 added Priority 0 and removed blocked needs something from nearcore labels Feb 4, 2020
@icerove icerove added the blocked needs something from nearcore label Feb 8, 2020
@kcole16 kcole16 removed the blocked needs something from nearcore label Feb 10, 2020
@icerove
Copy link
Contributor

icerove commented Feb 15, 2020

wait for near/nearcore#2109
@kcole16

@frol
Copy link
Collaborator

frol commented Feb 26, 2020

@icerove Why exactly are we waiting for near/nearcore#2109?

It seems that this issue is only blocked by near/near-api-js#242

@icerove
Copy link
Contributor

icerove commented Feb 28, 2020

I think gas price can be extracted from block header we already have

@frol
Copy link
Collaborator

frol commented Feb 28, 2020

We can do that as well, but pushing nearlib is not that hard as well.

@icerove
Copy link
Contributor

icerove commented Feb 28, 2020

Definitely can, but it will be slower since we go into nearlib and wait for query again to get gas price. Does not make more sense to do so. Still do the work to expose gas price in the nearlib.

@frol
Copy link
Collaborator

frol commented Feb 28, 2020

It is unclear why do you think we already have information about a block header on the transaction details page. I assume we don't have this information there, which means you will need to query it, and gas price response is tiny while block query returns the whole header and all the chunks headers.

@icerove icerove mentioned this issue Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants